Export InstrumentationAbstract from @opentelemetry/instrumentation #4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4507 +/- ##
==========================================
+ Coverage 91.99% 92.40% +0.41%
==========================================
Files 320 330 +10
Lines 9342 9531 +189
Branches 1992 2036 +44
==========================================
+ Hits 8594 8807 +213
+ Misses 748 724 -24 |
|
@pichlermarc do you think it'd be possible to get this in (assuming you're ok with the change of course) before the next release? Hoping to update these deps in the esbuild plugin which should be the last blocker |
|
@drewcorlin1 hmm, does checking for |
Indeed it does, ignore me! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Export
InstrumentationAbstractso it can be used in https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1856/files. I'll need to check if items returns bygetNodeAutoInstrumentationsare instances of this class so I can callgetModuleDefinitionson them.Fixes # (issue)
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: